tillrohrmann commented on a change in pull request #10228: [FLINK-14816] Add
thread dump feature for taskmanager
URL: https://github.com/apache/flink/pull/10228#discussion_r408295978
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -904,6 +906,8 @@ public void heartbeatFromResourceManager(ResourceID
resourceID) {
case STDOUT:
filePath =
taskManagerConfiguration.getTaskManagerStdoutPath();
break;
+ case THREAD_DUMP:
+ return
putTransientBlobStream(JvmUtils.threadDumpStream(), fileType);
Review comment:
I think it would be good to add a test for the thread dump feature (e.g.
testing that `TaskExecutorGateway#requestThreadDump()` will return the blob key
to a thread dump file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
