rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add 
basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408277189
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -170,9 +173,14 @@
 
        private final CompletableFuture<Void> closeFuture;
 
+       @Nullable
+       protected BufferReceivedListener bufferReceivedListener;
 
 Review comment:
   I don't think `synchronized` will speed up `volatile` read. But I'm also not 
sure what the performance impact is in the first place so I'm fine with this 
approach.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to