wuchong commented on a change in pull request #11674:
[FLINK-16887][table-planner-blink] Refactor retraction rules to support
inferring ChangelogMode
URL: https://github.com/apache/flink/pull/11674#discussion_r408223133
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/api/stream/ExplainTest.xml
##########
@@ -45,11 +45,11 @@ LogicalProject(EXPR$0=[$1])
+- LogicalTableScan(table=[[default_catalog, default_database,
MyTable1]])
== Optimized Logical Plan ==
-Calc(select=[EXPR$0], updateAsRetraction=[false], accMode=[Acc]): rowcount = ,
cumulative cost = {rows, cpu, io, network, memory}
-+- GroupAggregate(groupBy=[a], select=[a, COUNT(*) AS EXPR$0],
updateAsRetraction=[false], accMode=[Acc]): rowcount = , cumulative cost =
{rows, cpu, io, network, memory}
- +- Exchange(distribution=[hash[a]], updateAsRetraction=[true],
accMode=[Acc]): rowcount = , cumulative cost = {rows, cpu, io, network, memory}
- +- Calc(select=[a], updateAsRetraction=[true], accMode=[Acc]): rowcount
= , cumulative cost = {rows, cpu, io, network, memory}
- +- DataStreamScan(table=[[default_catalog, default_database,
MyTable1]], fields=[a, b, c], updateAsRetraction=[true], accMode=[Acc]):
rowcount = , cumulative cost = {rows, cpu, io, network, memory}
+Calc(select=[EXPR$0], changelogMode=[I,UA]): rowcount = , cumulative cost =
{rows, cpu, io, network, memory}
Review comment:
Because we are using `ONLY_UPDATE_AFTER` as the default required trait for
queries without sink. This is set in
[StreamCommonSubGraphBasedOptimizer.scala#L60](https://github.com/wuchong/flink/blob/9dcfd29d468b25f245e7b178ea4ae1a331ea6b39/flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/StreamCommonSubGraphBasedOptimizer.scala#L60)
and passed by `StreamOptimizeContext#isUpdateBeforeRequired`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
