rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add
basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407975091
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -542,6 +579,13 @@ public void onBuffer(Buffer buffer, int sequenceNumber,
int backlog) throws IOEx
if (backlog >= 0) {
onSenderBacklog(backlog);
}
+
+ if (notifyReceivedBarrier != null) {
+ receivedCheckpointId =
notifyReceivedBarrier.getId();
Review comment:
I'm concerned about `receivedCheckpointId` thread-safety:
1. we don't "flush" this write, so the other thread can never see it at line
564 above (even the other thread is in `synchronized` block, it doesn't force
**this** thread write)
2. if two threads arrive at this point with different barriers then one can
override other's value; so we can get older `receivedCheckpointId` written
(this is not prevented by `in-flight-barriers=1`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
