dianfu commented on a change in pull request #11714: [FLINK-17114][python] Set 
the default value of 'python.executable' to the path of the python interpreter 
which launches the job when the job is executed by LocalExecutor.
URL: https://github.com/apache/flink/pull/11714#discussion_r407456184
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -1082,6 +1086,13 @@ def _from_elements(self, elements, schema):
         finally:
             os.unlink(temp_file.name)
 
+    def _set_python_executable_for_local_executor(self):
+        jvm = get_gateway().jvm
+        j_config = get_j_env_configuration(self)
+        if not j_config.containsKey(jvm.PythonOptions.PYTHON_EXECUTABLE.key()) 
\
 
 Review comment:
   Should we consider the case when a user has set the `python.executable` via 
`table_config.get_configuration()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to