docete commented on a change in pull request #11712:
[FLINK-17067][FLINK-17098][table] Refactor some interfaces of CatalogManager
URL: https://github.com/apache/flink/pull/11712#discussion_r407412568
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/catalog/CatalogManagerTest.java
##########
@@ -102,19 +102,20 @@ public void testRegisterCatalogWithExistingName() throws
Exception {
}
@Test
- public void testReplaceTemporaryTable() throws Exception {
+ public void testIgnoreTemporaryTableExists() throws Exception {
ObjectIdentifier tempIdentifier = ObjectIdentifier.of(
BUILTIN_CATALOG_NAME,
BUILTIN_DEFAULT_DATABASE_NAME,
"temp");
CatalogManager manager = root()
.builtin(
database(BUILTIN_DEFAULT_DATABASE_NAME))
- .temporaryTable(tempIdentifier)
.build();
CatalogTest.TestTable table = new CatalogTest.TestTable();
manager.createTemporaryTable(table, tempIdentifier, true);
+ CatalogTest.TestTable anotherTable = new
CatalogTest.TestTable();
+ manager.createTemporaryTable(anotherTable, tempIdentifier,
true);
Review comment:
The next `testTemporaryTableExists` test the case "ignoreIfExists=false"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
