zhijiangW commented on a change in pull request #11687:
[FLINK-16536][network][checkpointing] Implement InputChannel state recovery for
unaligned checkpoint
URL: https://github.com/apache/flink/pull/11687#discussion_r407224535
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -95,7 +95,7 @@ public LocalInputChannel(
//
------------------------------------------------------------------------
@Override
- protected void requestSubpartition(int subpartitionIndex) throws
IOException, InterruptedException {
+ protected void requestSubpartition() throws IOException,
InterruptedException {
Review comment:
I actually considered whether to extract it as a separate commit or not when
implementation. I think both ways can be interpreted from different
motivations.
- If making it as a separate hotfix or refactor commit, we only save one
argument from this interface method and fetch it from `SingleInputGate`
instead. Then the benefit seems not very obvious if without the following input
recovery change.
- If making it along with the input recovery changes, the motivation seems a
must-work to do. Since we migrate the actual usage of this argument outside of
this method, then this argument should also be cleaned up as a result.
Therefore I preferred a bit not to make it a separate commit before. It is
fine for my either ways actually. If you are in favor of separate commit, i am
willing to change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
