godfreyhe commented on a change in pull request #11674:
[FLINK-16887][table-planner-blink] Refactor retraction rules to support
inferring ChangelogMode
URL: https://github.com/apache/flink/pull/11674#discussion_r407155058
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/RelNodeBlock.scala
##########
@@ -146,14 +153,30 @@ class RelNodeBlock(val outputNode: RelNode) {
def getOptimizedPlan: RelNode = optimizedPlan.orNull
- def setUpdateAsRetraction(updateAsRetract: Boolean): Unit = {
- // set child block updateAsRetract, a child may have multi father.
- if (updateAsRetract) {
- this.updateAsRetract = true
+ // TODO: not needed?
+ def setRequiredModifyKindSet(modifyKindSet: ModifyKindSet, requester:
String): Unit = {
Review comment:
remove this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
