pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406772498
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -146,6 +163,31 @@ private boolean add(BufferConsumer bufferConsumer,
boolean finish) {
return true;
}
+ private void handleAddingBarrier(BufferConsumer bufferConsumer, boolean
insertAsHead) {
+ assert Thread.holdsLock(buffers);
+ if (insertAsHead) {
+ // Note here we assume there is only one checkpoint
triggered at a time. If we want to support
+ // multiple checkpoints running at the same time, we
need maintain a map for in-flight buffers.
+ inflightBufferSnapshot.clear();
Review comment:
nit: it might be more safe to assert here that `inflightBufferSnapshot` is
clear, and clear it upon reading (we could either change
`getInflightBufferSnapshot()` to return array and clear the buffers in the
"getter", or return copy of the list ?)
Also `#getInflightBufferSnapshot()` is not being tested in any way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
