hequn8128 commented on a change in pull request #11650: [FLINK-16687][python]
Support Python UDF in Java Correlate
URL: https://github.com/apache/flink/pull/11650#discussion_r406111211
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/rules/logical/PythonCorrelateSplitRule.java
##########
@@ -185,36 +186,59 @@ private FlinkLogicalCalc createTopCalc(
rexBuilder));
}
+ private ScalarFunctionSplitter createScalarFunctionSplitter(
+ int primitiveLeftFieldCount,
+ ArrayBuffer<RexCall> extractedRexCalls,
+ boolean isJavaTableFunction) {
+ if (isJavaTableFunction) {
Review comment:
Can be simplified as:
```
return new ScalarFunctionSplitter(
primitiveLeftFieldCount,
extractedRexCalls,
isJavaTableFunction ? x -> PythonUtil.isPythonCall(x,
null) : PythonUtil::isNonPythonCall
);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
