AHeise commented on a change in pull request #11515: [FLINK-16744][task] 
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r405012353
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -277,7 +277,8 @@ protected StreamTask(
                        getCancelables(),
                        getAsyncOperationsThreadPool(),
                        getEnvironment(),
-                       this);
+                       this,
+                       false); // todo: pass true if unaligned checkpoints 
enabled
 
 Review comment:
   Usually, we don't want to push TODOs into master, but I can see that it has 
some value. On the other hand, it should be quite easy to find when actually 
adding unaligned checkpoints.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to