JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] 
Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r404509998
 
 

 ##########
 File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BaseArraySerializer.java
 ##########
 @@ -134,6 +139,48 @@ private GenericArray copyGenericArray(GenericArray array) 
{
                return new GenericArray(arr, array.numElements(), 
array.isPrimitiveArray());
        }
 
+       private GenericArray copyColumnarArray(ColumnarArray from) {
+               Object arr;
+               boolean isPrimitiveArray = true;
+               switch (eleType.getTypeRoot()) {
+                       case BOOLEAN:
+                               arr = from.toBooleanArray();
 
 Review comment:
   We can invoke toPrimitiveArray only then nullable is false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to