danny0405 commented on a change in pull request #11568: [FLINK-16779][table] 
Add RAW type support in DDL and functions
URL: https://github.com/apache/flink/pull/11568#discussion_r404506126
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
 ##########
 @@ -484,6 +493,9 @@ object FlinkTypeFactory {
       // CURSOR for UDTF case, whose type info will never be used, just a 
placeholder
       case CURSOR => new TypeInformationRawType[Nothing](new NothingTypeInfo)
 
+      case null if relDataType.isInstanceOf[RawRelDataType] =>
 
 Review comment:
   > Because Calcite assumes that an ANY type does not need further parameters
   Calcite does not have such assumption. Maybe what you meant is a 
`BasicSqlType` with `SqlTypeName.ANY` does not need further parameters.
   
   The `SqlTypeName` is a way to categorize these `RelDataType`, it does not 
indicates anything about the type instance itself.
   
   I'm confused by "if this is actually not a SQL type", if we can use the 
`RAW(...)` in DDL or other DQLs, it is a SQL type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to