zentol commented on a change in pull request #11639: [FLINK-16626][runtime]
Prevent REST handler from being closed more than once
URL: https://github.com/apache/flink/pull/11639#discussion_r404159729
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
##########
@@ -500,6 +500,15 @@ public WebMonitorEndpoint(
JobCancellationHeaders.getInstance(),
TerminationModeQueryParameter.TerminationMode.CANCEL);
+ // this is to prevent the same JobCancellationHandler from
being registered twice
+ // should be removed once the Yarn proxy can forward all REST
verbs
+ final JobCancellationHandler legacyJobCancelTerminationHandler
= new JobCancellationHandler(
Review comment:
We can be a bit more specific with the naming
```suggestion
final JobCancellationHandler yarnJobCancelTerminationHandler =
new JobCancellationHandler(
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
