xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r403793315
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1054,10 +1054,10 @@ protected abstract void internalDeregisterApplication(
* Allocates a resource using the resource profile.
*
* @param resourceProfile The resource description
- * @return Collection of {@link ResourceProfile} describing the
launched slots
+ * @return whether the resource can be allocated
*/
@VisibleForTesting
- public abstract Collection<ResourceProfile>
startNewWorker(ResourceProfile resourceProfile);
+ public abstract boolean startNewWorker(ResourceProfile resourceProfile);
Review comment:
In this commit, we have moved the logics of calculating number of new
pending slots into `SlotManagerImpl`. Therefore, `SlotManagerImpl` only needs
to know whether the new worker is started or not, and should be able to
correctly calculate the number of available slots.
In the final state, RM accepts `WorkerResourceSpec` instead of slot
`ResourceProfile` for starting new workers. It would become a SM decision that
how many multiple of `ResourceProfile` the worker should be start with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
