zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic 
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r403726537
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1096,14 +1134,18 @@ void handleAsyncException(String message, Throwable 
exception) {
                private final 
AtomicReference<CheckpointingOperation.AsyncCheckpointState> 
asyncCheckpointState = new AtomicReference<>(
                        CheckpointingOperation.AsyncCheckpointState.RUNNING);
 
+               private final Future<?> bufferPersistingFuture;
 
 Review comment:
   My previous consideration was that it might improve readability if we can 
confirm the specific type already. 
   I agree with your point that the type is actually irrelevant and we can 
regard it as internal details of `ChannelStateWriter`. I have no other concerns 
for this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to