dianfu commented on a change in pull request #11598: [FLINK-16914][python] 
Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402148273
 
 

 ##########
 File path: 
flink-python/src/main/java/org/apache/flink/table/runtime/arrow/ArrowUtils.java
 ##########
 @@ -223,39 +239,43 @@ private static Field toArrowField(RowType.RowField 
rowField) {
 
        private static ArrowFieldWriter<BaseRow> 
createBaseRowArrowFieldWriter(FieldVector vector, LogicalType fieldType) {
 
 Review comment:
   Good catch! Updated the result type. However, have not added a new test as 
this is already covered in the BaseRowArrowReaderWriterTest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to