GJL edited a comment on issue #11542: [FLINK-16303][rest] Enable retrieval of 
custom JobManager log files
URL: https://github.com/apache/flink/pull/11542#issuecomment-607162932
 
 
   > I don't agree to split this ticket into two.
   > The purpose of adding JobManagerLogListHandler is to allow the user to 
view the logs by custom.
   
   From my point of view, `JobManagerLogListHandler` lists the available log 
files. The ability to view the contents of the log files is a different story. 
Could we have implemented `JobManagerLogListHandler` independently from the 
other work in this PR? If yes, then I think we should have done it because it 
makes the review easier. For a Flink user it doesn't make a difference since 
the Web UI is not yet ready. I am not saying we should split the ticket now but 
for future tasks this is something to consider.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to