zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r401345542
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/over/BufferDataOverWindowOperatorTest.java
##########
@@ -205,9 +206,19 @@ public StreamConfig getOperatorConfig() {
@Override
public StreamTask<?, ?> getContainingTask() {
- StreamTask task = mock(StreamTask.class);
+ class MockableStreamTask extends
StreamTask<Object, StreamOperator<Object>> implements EnvironmentSupport {
+ MockableStreamTask() throws Exception {
+ super(new
MockEnvironmentBuilder().build());
+ }
+
+ @Override
+ protected void init() {
+ }
+ }
+
+ StreamTask<?, ?> task =
mock(MockableStreamTask.class);
Review comment:
TBH i did not get the point why this class change is related to the commit
motivation.
If it is necessary, can we use `MockStreamTaskBuilder` to build
`MockStreamTask` instead, to avoid construct `MockableStreamTask`. Besides
that, it is not suggested to use `mock` in unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
