zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic 
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400304625
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1144,6 +1186,9 @@ public void run() {
 
                                
checkpointMetrics.setAsyncDurationMillis(asyncDurationMillis);
 
+                               bufferPersistingFuture.get();
+
+                               LOG.debug("{}: Finished checkpoint {}.", 
owner.getName(), checkpointMetaData.getCheckpointId());
 
 Review comment:
   I guess this log is not necessary. Otherwise the whole log stacks would be 
following:
   
   `Finished synchronous checkpoints.......`
   `Finished checkpoint......`
   `finished synchronous part of checkpoint.....`
   
   It might confuse users.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to