rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add
basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399512927
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -206,6 +210,20 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException {
return Optional.of(new BufferAndAvailability(next,
moreAvailable, getSenderBacklog()));
}
+ @Override
+ public List<Buffer> getInflightBuffers(long checkpointId) throws
IOException {
+ final ArrayList<Buffer> inflightBuffers = new
ArrayList<>(receivedBuffers.size());
Review comment:
This collection (`receivedBuffers`) is not thread-safe, so its contract
makes no sense in a multi-threaded environment.
Yes, it's only a hint. But if it's negative, we'll get an exception.
`syncrhonized` has a cost, which I think will be higher here than potential
re-allocation in `ArrayList`.
So I'd just remove it or guard against negative values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
