zentol commented on a change in pull request #11314: [FLINK-16411][AZP] Use
google mvn mirror globally
URL: https://github.com/apache/flink/pull/11314#discussion_r398397692
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -160,14 +160,17 @@ jobs:
echo "##vso[task.setvariable variable=PATH]$JAVA_HOME_11_X64/bin:$PATH"
displayName: "Set to jdk11"
condition: eq('${{parameters.jdk}}', 'jdk11')
- - script: ./tools/travis/setup_maven.sh
+ - script: |
+ source ./tools/ci/maven-utils.sh
+ setup_maven
+ echo "##vso[task.setvariable variable=M2_HOME]$M2_HOME"
Review comment:
> But that would install maven in the user's home directory, when running
the script locally.
Fair point, but didn't you argue previously that no one should use
`run-nightly-tests.sh` anyway since it installs so many things? I thought we
relegated this script to only be used for azure.
> I should actually remove the export PATH=${M2_HOME}/bin:${PATH} line from
the setup_maven function.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
