rkhachatryan commented on a change in pull request #11486: [FLINK-16712][task]
Refactor StreamTask to construct final fields
URL: https://github.com/apache/flink/pull/11486#discussion_r396601796
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -260,17 +258,28 @@ protected StreamTask(
@Nullable TimerService timerService,
Thread.UncaughtExceptionHandler
uncaughtExceptionHandler,
StreamTaskActionExecutor actionExecutor,
- TaskMailbox mailbox) {
+ TaskMailbox mailbox) throws Exception {
Review comment:
If I'm not mistaken, these exceptions were previously thrown from
`StreamTask.invoke()`; and then they weren't wrapped into anything neither by
`StreamTask` nor by `Task`.
Now they are thrown from `Task.loadAndInstantiateInvokable` which can wrap
them into `FlinkException`.
This wrapping can break exception-matching logic in `Task` (e.g. `if (t
instanceof CancelTaskException) ...`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
