vthinkxie commented on a change in pull request #11356: [FLINK-15000] [web]
WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#discussion_r396577250
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.ts
##########
@@ -64,15 +71,35 @@ export class JobOverviewDrawerChartComponent implements
OnInit, OnDestroy {
closeMetric(metric: string) {
this.listOfSelectedMetric = this.listOfSelectedMetric.filter(item => item
!== metric);
this.jobService.metricsCacheMap.set(this.cacheMetricKey,
this.listOfSelectedMetric);
+ this.showList = [metric,...this.showList];
this.updateUnselectedMetricList();
}
updateUnselectedMetricList() {
this.listOfUnselectedMetric = this.listOfMetricName.filter(item =>
this.listOfSelectedMetric.indexOf(item) === -1);
+ this.showList = this.showList.filter(item =>
this.listOfSelectedMetric.indexOf(item) === -1);
+ this.optionList = this.listOfUnselectedMetric;
}
constructor(private metricsService: MetricsService, private jobService:
JobService, private cdr: ChangeDetectorRef) {}
+ nzOnSearch(val: string){
+ this.showListPageNum=0;
Review comment:
there will be a pre commit hook after you install the node_modules, it will
format the code automaticlly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
