zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] 
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r396264764
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -140,6 +141,8 @@
        /** Channels, which notified this input gate about available data. */
        private final ArrayDeque<InputChannel> inputChannelsWithData = new 
ArrayDeque<>();
 
+       private final HashMap<Integer, InputChannel> 
channelsBlockedByCheckpoint = new HashMap<>();
 
 Review comment:
   It is better to reuse the blocked states from `CheckpointBarrierAligner` if 
possible to avoid managing it duplicated in another place and causing potential 
inconsistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to