zhengcanbin commented on issue #11472: [FLINK-16547][yarn] Respect the config option of FileJobGraphRetriever#JOB_GRAPH_FILE_PATH URL: https://github.com/apache/flink/pull/11472#issuecomment-602436628 > Thanks for the work @zhengcanbin and for the review @TisonKun. I will merge this. > > Side note for a potential future JIRA: in the `startAppMaster()` method we are using sometime the `configuration` argument to the method to get/set config options, and sometime the `flinkConfiguration` which is a class member. Shouldn't we always use the `configuration` argument? This will make the method more self-contained. Thanks for the review @kl0u @TisonKun! I am in favor of always using the `configuration` argument to make the method more self-contained. I would like to create a tracking JIRA.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
