azagrebin commented on issue #11445: [FLINK-16615] Introduce data structures 
and utilities to calculate Job Manager memory components
URL: https://github.com/apache/flink/pull/11445#issuecomment-602426159
 
 
   Thanks for the review @xintongsong 
   I refactored more the class structure. The final composition is a bit 
different but goes into a similar direction. This should also allow better test 
separation (probably later) comparing to the inheritance approach which is also 
in one of commits.
   I also addressed smaller comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to