zhengcanbin commented on a change in pull request #11415: [FLINK-15667][k8s] Support to mount custom Hadoop configurations URL: https://github.com/apache/flink/pull/11415#discussion_r396219077
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParameters.java ########## @@ -134,6 +136,33 @@ public boolean hasLog4j() { return log4jFile.exists(); } + @Override + public Optional<String> getExistingHadoopConfigurationConfigMap() { + final String existingHadoopConfigMap = flinkConfig.getString(KubernetesConfigOptions.HADOOP_CONF_CONFIG_MAP); + if (StringUtils.isBlank(existingHadoopConfigMap)) { + return Optional.empty(); + } else { + return Optional.of(existingHadoopConfigMap.trim()); + } + } + + @Override + public Optional<String> getLocalHadoopConfigurationDirectory() { + final String[] possibleHadoopConfPaths = new String[] { + System.getenv(Constants.ENV_HADOOP_CONF_DIR), + System.getenv(Constants.ENV_HADOOP_HOME + "/etc/hadoop"), // hadoop 2.2 Review comment: You are right! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services