ifndef-SleePy commented on a change in pull request #11347:
[FLINK-14971][checkpointing] Make all the non-IO operations in
CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r395431078
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -151,6 +149,9 @@
* It must be single-threaded. Eventually it will be replaced by main
thread executor. */
private final ScheduledExecutor timer;
+ @Nullable
+ private ComponentMainThreadExecutor mainThreadExecutor;
Review comment:
Yes, it could not be a `final` variable based on current implementation of
`ExecutionGraph`. I'm just not a fan of the trick of
`DummyComponentMainThreadExecutor`. But I agree with you that it's not a bad
idea to provide a consistent way with `ExecutionGraph`. Let me think of it a
bit more. Maybe we could find a better solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
