afedulov commented on a change in pull request #11195: [FLINK-16222][runtime]
Use plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r395375423
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/FlinkDistribution.java
##########
@@ -260,16 +262,26 @@ public void submitSQLJob(SQLJobSubmission job) throws
IOException {
}
public void copyOptJarsToLib(String jarNamePrefix) throws
FileNotFoundException, IOException {
- final Optional<Path> reporterJarOptional;
- try (Stream<Path> logFiles = Files.walk(opt)) {
- reporterJarOptional = logFiles
+ copyOptJars(jarNamePrefix, lib);
+ }
+
+ public void copyOptJarsToPlugins(String jarNamePrefix) throws
FileNotFoundException, IOException {
Review comment:
But this is not really "copying jars", right? It will actually move the file
from opt to lib or plugins. The problem is that one of the cases I would like
to test required the jar to be actually copied to both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
