GJL commented on a change in pull request #11250: [FLINK-16302][rest]add log
list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r394942814
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerStdoutFileHandler.java
##########
@@ -53,7 +54,7 @@ public TaskManagerStdoutFileHandler(
}
@Override
- protected CompletableFuture<TransientBlobKey>
requestFileUpload(ResourceManagerGateway resourceManagerGateway, ResourceID
taskManagerResourceId) {
- return
resourceManagerGateway.requestTaskManagerFileUpload(taskManagerResourceId,
FileType.STDOUT, timeout);
+ protected CompletableFuture<TransientBlobKey>
requestFileUpload(ResourceManagerGateway resourceManagerGateway,
Tuple2<ResourceID, String> taskmanagerId2FileName) {
Review comment:
`taskmanagerIdAndFileName`, to be consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
