TisonKun commented on a change in pull request #11435: [FLINK-15852][cli]
Prioritize ExecutorCLI over YarnSessionCLI for activeCLI
URL: https://github.com/apache/flink/pull/11435#discussion_r394905006
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java
##########
@@ -161,6 +168,41 @@ public void testNodeLabelProperty() throws Exception {
assertEquals(nodeLabelCliInput, descriptor.getNodeLabel());
}
+ @Test
+ public void testExecutorCLIisPrioritised() throws Exception {
+ final File directoryPath =
writeYarnPropertiesFile(validPropertiesFile);
+
+ final Configuration configuration = new Configuration();
+
configuration.setString(YarnConfigOptions.PROPERTIES_FILE_LOCATION,
directoryPath.getAbsolutePath());
+
+ validateYarnCLIisActive(configuration);
+
+ final String[] argsUnderTest = new String[] {"-e",
YarnJobClusterExecutor.NAME};
+
+ validateExecutorCLIisPrioritised(configuration, argsUnderTest);
+ }
+
+ private void validateExecutorCLIisPrioritised(Configuration
configuration, String[] argsUnderTest) throws IOException, CliArgsException {
Review comment:
```suggestion
private void validateExecutorCLIIsPrioritized(Configuration
configuration, String[] argsUnderTest) throws IOException, CliArgsException {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
