[ 
https://issues.apache.org/jira/browse/FLINK-15640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060029#comment-17060029
 ] 

Yang Wang edited comment on FLINK-15640 at 3/19/20, 9:20 AM:
-------------------------------------------------------------

Hi [~hippo], sorry for the late response. Do you still want to work on this 
ticket?


was (Author: fly_in_gis):
Hi [~hippo], sorry for the late response. Do you still want to work on this 
ticket?

I have reconsidered the configuration. Maybe using the prefix schema is better. 
For example, {{kubernetes.jobmanager.labels.my-label=my-label-value}}. This is 
more flexible and friendly to the Flink job deployer.

> Support to set label and node selector
> --------------------------------------
>
>                 Key: FLINK-15640
>                 URL: https://issues.apache.org/jira/browse/FLINK-15640
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Kubernetes
>            Reporter: Yang Wang
>            Priority: Major
>
> Navigate to [Kubernetes 
> doc|https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/]
>  for more information.
> {code:java}
> public static final ConfigOption<String> JOB_MANAGER_USER_LABELS =
>  key("kubernetes.jobmanager.labels")
>   .noDefaultValue()
>   .withDescription("The labels to be set for JobManager replica controller, 
> service and pods. " +
>    "Specified as key:value pairs separated by commas. such as 
> version:alphav1,deploy:test.");
> public static final ConfigOption<String> TASK_MANAGER_USER_LABELS =
>  key("kubernetes.taskmanager.labels")
>   .noDefaultValue()
>   .withDescription("The labels to be set for TaskManager pods. " +
>    "Specified as key:value pairs separated by commas. such as 
> version:alphav1,deploy:test.");
> public static final ConfigOption<String> JOB_MANAGER_NODE_SELECTOR =
>  key("kubernetes.jobmanager.node-selector")
>   .noDefaultValue()
>   .withDescription("The node-selector to be set for JobManager pod. " +
>    "Specified as key:value pairs separated by commas. such as 
> environment:dev,tier:frontend.");
> public static final ConfigOption<String> TASK_MANAGER_NODE_SELECTOR =
>  key("kubernetes.taskmanager.node-selector")
>   .noDefaultValue()
>   .withDescription("The node-selector to be set for TaskManager pods. " +
>    "Specified as key:value pairs separated by commas. such as 
> environment:dev,tier:frontend.");
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to