TisonKun commented on a change in pull request #11415: [FLINK-15667][k8s]
Support to mount custom Hadoop configurations
URL: https://github.com/apache/flink/pull/11415#discussion_r394864583
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/factory/KubernetesJobManagerFactoryTest.java
##########
@@ -69,6 +71,9 @@ public void setup() throws Exception {
flinkConfig.set(KubernetesConfigOptionsInternal.ENTRY_POINT_CLASS,
ENTRY_POINT_CLASS);
flinkConfig.set(KubernetesConfigOptions.JOB_MANAGER_SERVICE_ACCOUNT,
SERVICE_ACCOUNT_NAME);
+ setHadoopConfDirEnv();
Review comment:
We might possibly have a subclass of this test class so that don't pollute
global settings. Also it seems we don't test existing hadoop conf case and
empty local hadoop conf case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
