jinglining commented on a change in pull request #11250: [FLINK-16302][rest]add
log list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r394117551
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1647,6 +1660,30 @@ private boolean isJobManagerConnectionValid(JobID
jobId, JobMasterId jobMasterId
return jmConnection != null &&
Objects.equals(jmConnection.getJobMasterId(), jobMasterId);
}
+ private CompletableFuture<TransientBlobKey>
requestFileUploadByFilePath(String filePath, Time timeout, String fileTag) {
Review comment:
This parameter is from the method in TaskExecutorGateway, and it's
RpcTimeout(**ps: Annotation for {@link RpcGateway} methods to specify an
additional timeout parameter for the returned future to be completed. The rest
of the provided parameters is passed to the remote rpc server for the rpc.**),
so we need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
