tillrohrmann commented on a change in pull request #11408:
[FLINK-15989][FLINK-16225] Improve direct and metaspace out-of-memory error
handling
URL: https://github.com/apache/flink/pull/11408#discussion_r393778126
##########
File path: flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java
##########
@@ -109,6 +131,26 @@ public static boolean
isJvmFatalOrOutOfMemoryError(Throwable t) {
return isJvmFatalError(t) || t instanceof OutOfMemoryError;
}
+ /**
+ * Checks whether the given exception indicates a JVM metaspace
out-of-memory error.
+ *
+ * @param t The exception to check.
+ * @return True, if the exception is the metaspace {@link
OutOfMemoryError}, false otherwise.
+ */
+ public static boolean isMetaspaceOutOfMemoryError(Throwable t) {
+ return t instanceof OutOfMemoryError &&
t.getMessage().startsWith("Metaspace");
+ }
+
+ /**
+ * Checks whether the given exception indicates a JVM direct
out-of-memory error.
+ *
+ * @param t The exception to check.
+ * @return True, if the exception is the direct {@link
OutOfMemoryError}, false otherwise.
+ */
+ public static boolean isDirectOutOfMemoryError(Throwable t) {
+ return t instanceof OutOfMemoryError &&
t.getMessage().startsWith("Direct buffer memory");
+ }
Review comment:
How reliable is this test across different JVM implementations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
