rmetzger commented on a change in pull request #11372: [FLINK-16480] Improve
error reporting on AZP
URL: https://github.com/apache/flink/pull/11372#discussion_r393569642
##########
File path: tools/travis_watchdog.sh
##########
@@ -177,6 +177,14 @@ print_stacktraces () {
done
}
+collect_coredumps() {
+ echo "Searching for .dump, .dumpstream and related files in
$($HERE/../)"
+ for file in `find . -type f -regextype posix-extended -iregex
'.*\.dump|.*\.dumpstream|.*hs.*\.log|.*/core(.[0-9]+)?$'`; do
Review comment:
With this implementation, we can use this function also for collecting any
JVM debugging files from the end to end tests.
Yes, we could also inject JVM properties through environment variables into
most of the end to end tests. But who guarantees that Kafka, ElasticSearch,
Zookeeper all properly respect the environment variables.
With this approach, I'm following a blackbox approach where I don't trust
the system I'm testing.
Also, I don't know if I would spend my time well for the project if I would
refactor something that works. Coredumps (luckily) happen quite rarely. I just
wanted to make life for others easier when they have to debug a crashing JVM on
a CI system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
