afedulov commented on a change in pull request #11195: [FLINK-16222][runtime] 
Use plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r393563258
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
 ##########
 @@ -160,13 +161,14 @@ public void startCluster() throws 
ClusterEntrypointException {
                LOG.info("Starting {}.", getClass().getSimpleName());
 
                try {
-
-                       configureFileSystems(configuration);
+                       //TODO: push down filesystem initialization into 
runCluster - initializeServices (?)
 
 Review comment:
   @AHeise I wanted to ask if what is written in TODO is a good idea in your 
opinion. I am not sure about the implications of initializing FileSystems 
within `runSecured`. I do not quite like that initialization if services 
(initializeServices) and  file systems happen in different places. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to