[ https://issues.apache.org/jira/browse/FLINK-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060374#comment-17060374 ]
Nico Kruber commented on FLINK-6763: ------------------------------------ [~tzulitai] given that you had a PR for this a while back and it still didn't make it into the code base, and also [~sewen]'s suggesting would make this whole optimisation obsolete (if you only do this once, you don't care about this cost too much), what are the plans regarding this ticket? > Inefficient PojoSerializerConfigSnapshot serialization format > ------------------------------------------------------------- > > Key: FLINK-6763 > URL: https://issues.apache.org/jira/browse/FLINK-6763 > Project: Flink > Issue Type: Improvement > Components: API / Type Serialization System, Runtime / State Backends > Affects Versions: 1.3.0, 1.4.0 > Reporter: Till Rohrmann > Assignee: Tzu-Li (Gordon) Tai > Priority: Major > > The {{PojoSerializerConfigSnapshot}} stores for each serializer the beginning > offset and ending offset in the serialization stream. This information is > also written if the serializer serialization is supposed to be ignored. The > beginning and ending offsets are stored as a sequence of integers at the > beginning of the serialization stream. We store this information to skip > broken serializers. > I think we don't need both offsets. Instead I would suggest to write the > length of the serialized serializer first into the serialization stream and > then the serialized serializer. This can be done in > {{TypeSerializerSerializationUtil.writeSerializer}}. When reading the > serializer via {{TypeSerializerSerializationUtil.tryReadSerializer}}, we can > try to deserialize the serializer. If this operation fails, then we can skip > the number of serialized serializer because we know how long it was. -- This message was sent by Atlassian Jira (v8.3.4#803005)