zhijiangW commented on a change in pull request #11400: [FLINK-16586][network]
Build ResultSubpartitionInfo and InputChannelInfo in respective constructors
URL: https://github.com/apache/flink/pull/11400#discussion_r392247611
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -217,6 +218,7 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
for (InputGateDeploymentDescriptor igdd :
inputGateDeploymentDescriptors) {
SingleInputGate inputGate =
singleInputGateFactory.create(
ownerContext.getOwnerName(),
+ counter,
Review comment:
I guess your suggestion is for unifying all the related data structures
(collection, array) from `TaskDeploymentDescriptor.inputGates` to `List`?
Actually I do not see any correctness or performance problems ATM. This
unification really spans cross multiple components from scheduler to task
stack, and I do think it is really necessary to refactor it now. Or if we want
to do that, it should be a separate ticket out of this PR scope. We only make
use of previous `counter` to give a correct gate index while creating in
iteration for this PR motivation. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
