danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#discussion_r392008712
########## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/agg/GroupingSetsTest.scala ########## @@ -354,6 +355,8 @@ class GroupingSetsTest extends TableTestBase { @Test def testCALCITE1824(): Unit = { + expectedException.expect(classOf[TableException]) Review comment: Because of CALCITE-1824 has been fixed, the plan with `GROUP_ID` has changed, our blink-planner can not translate that yet. Before CALCITE-1824, `GROUP_ID` returns wrong result. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services