TisonKun commented on a change in pull request #11338: [FLINK-10052][ha] 
Tolerate temporarily suspended ZooKeeper connections
URL: https://github.com/apache/flink/pull/11338#discussion_r390926820
 
 

 ##########
 File path: docs/_includes/generated/expert_high_availability_zk_section.html
 ##########
 @@ -14,6 +14,12 @@
             <td>String</td>
             <td>Defines the ACL (open|creator) to be configured on ZK node. 
The configuration value can be set to “creator” if the ZooKeeper server 
configuration has the “authProvider” property mapped to use 
SASLAuthenticationProvider and the cluster is configured to run in secure mode 
(Kerberos).</td>
         </tr>
+        <tr>
+            
<td><h5>high-availability.zookeeper.client.connection-loss-tolerate</h5></td>
+            <td style="word-wrap: break-word;">true</td>
+            <td>Boolean</td>
+            <td>Defines whether or not leader election tolerates connection 
loss exception. Enable this option will improve the stability when ZK ensemble 
in an unstable network environment. For technical details, see FLINK-10052.</td>
 
 Review comment:
   It is an existing option 
   
   
https://github.com/apache/flink/blob/2a4a2e22c65756d95d3c378d42be11bb583bc01d/flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java#L131
   
   
https://github.com/apache/flink/blob/2a4a2e22c65756d95d3c378d42be11bb583bc01d/flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java#L171
   
   And here is the tech details if you're interested in it.
   
   
https://github.com/apache/curator/blob/959c1ca34f6ebcb11370180dfafbd8e85320dcd2/curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionState.java#L66-L81

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to