[ https://issues.apache.org/jira/browse/FLINK-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055800#comment-17055800 ]
Yun Gao commented on FLINK-10114: --------------------------------- Hi [~zenfenan], very thanks for the opinions. :) I also agree with that we could implement a new writer based on the low-level components. In fact , we have also tried to maintain a private branch for the orc lib and modify the _PhysicalFSWriter and WriterImpl_ to support writing to _OutputStream._ Similarly, I think we could also copy the PhysicalFSWriter out and modify it to support OutputStream, and using _WriterOption_ to apply the modified PhysicalWriter. However, I think the concerns should be similar: we have to maintain the codes by ourself and also have to ensure the rightness and performance of the new writer. It may also require some efforts to do sufficient test. That's also why I thought that a shaded module might be required, since we may use third-party writer implement (by us or some others), and we could hide the detail by using a shaded module and some abstract Factory interfaces. This also allows us to switch between implements more simpler. > Support Orc for StreamingFileSink > --------------------------------- > > Key: FLINK-10114 > URL: https://issues.apache.org/jira/browse/FLINK-10114 > Project: Flink > Issue Type: Sub-task > Components: Connectors / FileSystem > Reporter: zhangminglei > Assignee: vinoyang > Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)