dianfu commented on a change in pull request #11344: [FLINK-16250][python][ml]
Add interfaces for PipelineStage and Pipeline
URL: https://github.com/apache/flink/pull/11344#discussion_r390156849
##########
File path: flink-python/pyflink/ml/api/param/base.py
##########
@@ -164,17 +164,16 @@ def to_json(self) -> str:
import jsonpickle
return str(jsonpickle.encode(self._param_map, keys=True))
- def load_json(self, json: str) -> 'Params':
+ def load_json(self, json: str) -> None:
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
