TisonKun commented on a change in pull request #10526: [FLINK-15090][build]
Reverse the dependency from flink-streaming-java to flink-client
URL: https://github.com/apache/flink/pull/10526#discussion_r390070761
##########
File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
##########
@@ -128,16 +128,23 @@ public static void executeProgram(
LOG.info("Starting program (detached: {})",
!configuration.getBoolean(DeploymentOptions.ATTACHED));
- ContextEnvironmentFactory factory = new
ContextEnvironmentFactory(
+ ContextEnvironment benv = new ContextEnvironment(
Review comment:
I forget user could call ExecutionEnvironment multiple times. Generally
speaking these envs have same configuration but if we then modify them in user
code they should changed.
The motivation I do this change is from `OptimizerPlanEnvironment` where
return identical instance of env for all `getEnvironment` calls. However,
`StreamPlanEnvironment` is different instance.
As the semantic of `getEnvironment`, I think return different instance for
each call is reasonable.
Will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
