hequn8128 commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch URL: https://github.com/apache/flink/pull/11350#issuecomment-596369658 @carp84 Thanks a lot for the review. The license and notice file is removed just because the corresponding dependencies are not bundled into the jar. We don't necessarily bundle this dependency. This is because, currently, on release-1.10, only jar artifacts are released to maven and used by users, i.e., no binaries in opt or lib, so for ml users, he should add the dependencies to the pom file and set it to compile to include the ml classes. Meanwhile, the dependencies(`netlib:core`) will also be included. There is also another option to fix this problem as it is descript in the jira, i.e., bundle the dependency in the flink-ml-lib jar. But considering that it is not good to add dependencies in a hotfix version, I would suggest deleting the license and notice file directly. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
