Grzegorz Slowikowski created FLINK-16469:
--------------------------------------------

             Summary: Improve logging configurations
                 Key: FLINK-16469
                 URL: https://issues.apache.org/jira/browse/FLINK-16469
             Project: Flink
          Issue Type: Improvement
          Components: Command Line Client
            Reporter: Grzegorz Slowikowski


I'd like to propose several improvements to Log4J and Logback configuration 
files:

 

1 (bug).

In "logback.xml" and "logback-console.xml" some loggers define the same 
appender as root configuration. This leads to logs printed twice. Example:

current configuration:

<logger name="akka" level="INFO">
 <appender-ref ref="file"/>
 </logger>

proper configuration:

<logger name="akka" level="INFO"/>

 

2 (bug).

During Log4J to Log4J2 migration (commit 
[https://github.com/apache/flink/commit/e7db6b240572d08b549ea4ddb7b7b9ba719f7221)]
 log level for 
"org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline" 
logger was changed from ERROR to OFF.

Probably this change was accidental. If so, it should be reverted.

 

3 (improvement).

Currently "flink" script uses "log4j-cli.properties" and "logback.xml" 
configuration files. There is no "logback-cli.xml" file. "log4j-cli.properties" 
logs to file AND console ("log4j.properties" and "logback.xml" only to files. 
It would be good to have similar "-cli" configuration file for projects using 
Logback logging implementation. I would provide "logback-cli.xml" file and use 
it in "flink" script instead of "logback.xml".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to