TisonKun commented on a change in pull request #11296: [FLINK-16363] [table] 
Correct the execution behavior of TableEnvironment and StreamTableEnvironment
URL: https://github.com/apache/flink/pull/11296#discussion_r389051513
 
 

 ##########
 File path: 
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
 ##########
 @@ -783,6 +783,7 @@ class SqlITCase extends StreamingWithStateTestBase {
       new InMemoryTableFactory(3).createStreamTableSink(properties))
 
     tEnv.sqlUpdate("INSERT INTO targetTable SELECT a, b, c, rowtime FROM 
sourceTable")
+    tEnv.execute("job name")
 
 Review comment:
   > After we remove the deprecated methods (`sqlUpdate`, `insertInto`, 
`execute`, `explain`) in the future, the above scenario is also unsupported 
then. We just push the action ahead of time.
   
   @godfreyhe where is the background of this statement?
   
   I found it's quite confusing that why we have to run `execute` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to