TisonKun commented on a change in pull request #11320: [FLINK-16437][runtime]
Make SlotManager allocate resource from ResourceManager at the worker
granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388865522
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -804,22 +808,31 @@ private boolean
isFulfillableByRegisteredSlots(ResourceProfile resourceProfile)
}
private Optional<PendingTaskManagerSlot>
allocateResource(ResourceProfile resourceProfile) {
- final Collection<ResourceProfile> requestedSlots =
resourceActions.allocateResource(resourceProfile);
+ if (workerResourceSpec == null) {
+ // standalone mode, cannot allocate resource
Review comment:
It should be able to merge into `if
(!resourceActions.allocateResource(workerResourceSpec))` branch. But I am not
very sure because the next condition is
```
if (!Preconditions.checkNotNull(slotResourceProfile,
"slotResourceProfile should be null iff
workerResourceSpec is null, which means standalone mode.")
.isMatching(resourceProfile))
```
where we now have three profile(including workerResourceSpec) things become
quite complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
