zenfenan commented on a change in pull request #11307: [FLINK-16371]
[BulkWriter] Fix Hadoop Compression BulkWriter
URL: https://github.com/apache/flink/pull/11307#discussion_r388727756
##########
File path:
flink-formats/flink-compress/src/main/java/org/apache/flink/formats/compress/CompressWriterFactory.java
##########
@@ -77,4 +90,16 @@ public String codecExtension() {
: "";
}
+ private void initializeCompressionCodec() {
Review comment:
I believe this is fine. We are also loading the config from the map, if a
Hadoop configuration was provided. It makes sense to group them under a single
function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
